[libcxx-commits] [PATCH] D114282: [libc++] Remove uses of printf in some test support headers

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 19 14:29:19 PST 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Seems fine. Although I wonder if we could go further: These functions that check a bunch of stuff and return true-or-false, could they instead just //assert// all that stuff and return void?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114282/new/

https://reviews.llvm.org/D114282



More information about the libcxx-commits mailing list