[libcxx-commits] [PATCH] D114282: [libc++] Remove uses of printf in some test support headers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

In the test suite, we generally don't use printf or other reporting
utilities. It's not that it wouldn't be useful, it's just that some
platforms don't support IO.

Instead, we try to keep test cases small and self-contained so that
we can reasonably easily reproduce failures locally and debug them.
This patch removes printf in some of the last places in the test suite
that used it. The only remaining places are in a deque test and in the
filesystem tests. The filesystem tests are arguably fine to keep using
IO, since we're testing <filesystem>. The deque test will be handled
separately.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114282

Files:
  libcxx/test/support/controlled_allocators.h
  libcxx/test/support/type_id.h
  libcxx/test/support/uses_alloc_types.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114282.388620.patch
Type: text/x-patch
Size: 4949 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211119/b84fbb19/attachment.bin>