[libcxx-commits] [PATCH] D114242: [libc++] Fix some tests that were broken in the single-threaded configuration

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:657
+# For example, when threads are not supported, any test that includes
+# <thread> should be marked as UNSUPPORTED, because including <thread>
+# is a hard error in that case.
----------------
I find it interesting that including `<thread>` would be a hard error rather than a no-op like other "unsupported features" when it comes to including other headers (like ranges, concepts, etc.). No action required, but just an observation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114242/new/

https://reviews.llvm.org/D114242