[libcxx-commits] [PATCH] D114242: [libc++] Fix some tests that were broken in the single-threaded configuration

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D114242#3142767 <https://reviews.llvm.org/D114242#3142767>, @ldionne wrote:

> In D114242#3142762 <https://reviews.llvm.org/D114242#3142762>, @Mordante wrote:
>
>> LGTM when the CI is happy. Should we add a CI that test this configuration?
>
> Thanks for the review. We have CI for that configuration, however we don't have an actual C library that lacks support for threads. So we do have coverage, but it's not perfect. For each "freestanding slice" configuration, we could in theory create a small C library that forwards everything to the underlying C library, but which doesn't have the functionality we're excluding from that slice. But I believe that would reach diminishing returns.

Fair point. At some point it would be nice to have an actual "freestanding" C library for these test purposes. But I agree it would be a waste of our time to try to create that. (Unless we have somebody with too much time on their hands ;-) )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114242/new/

https://reviews.llvm.org/D114242