[libcxx-commits] [PATCH] D114094: [libc++] Refactor tests for trivially copyable atomics

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision as: libc++.
ldionne marked 2 inline comments as done.
ldionne added a comment.
This revision is now accepted and ready to land.

Will apply comments when committing.



================
Comment at: libcxx/test/std/atomics/atomics.types.generic/trivially_copyable.verify.cpp:20
+// We silence those to make the test more robust.
+// ADDITIONAL_COMPILE_FLAGS: -Xclang -verify-ignore-unexpected=error
+
----------------
Quuxplusone wrote:
> Consider exactly copy-pasting the comment wording from `libcxx/test/std/utilities/any/any.nonmembers/any.cast/const_correctness.verify.cpp`, just for hypothetical greppability.
Unfortunately, that comment is specific to `any_cast`, so it wouldn't apply here. However, for greppability, one could just look for `ADDITIONAL_COMPILE_FLAGS: -Xclang -verify-ignore-unexpected=error`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114094/new/

https://reviews.llvm.org/D114094