[libcxx-commits] [PATCH] D114094: [libc++] Refactor tests for trivially copyable atomics

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/atomics/atomics.types.generic/trivially_copyable.pass.cpp:27
 struct TriviallyCopyable {
-    TriviallyCopyable ( int i ) : i_(i) {}
+    TriviallyCopyable(int i) : i_(i) { }
     int i_;
----------------
Bonus nit here and in the new test: `explicit` constructors :)


================
Comment at: libcxx/test/std/atomics/atomics.types.generic/trivially_copyable.verify.cpp:20
+// We silence those to make the test more robust.
+// ADDITIONAL_COMPILE_FLAGS: -Xclang -verify-ignore-unexpected=error
+
----------------
Consider exactly copy-pasting the comment wording from `libcxx/test/std/utilities/any/any.nonmembers/any.cast/const_correctness.verify.cpp`, just for hypothetical greppability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114094/new/

https://reviews.llvm.org/D114094