[libcxx-commits] [PATCH] D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D112012#3136277 <https://reviews.llvm.org/D112012#3136277>, @mtrofin wrote:

> In D112012#3136235 <https://reviews.llvm.org/D112012#3136235>, @haowei wrote:
>
>> This change broke Fuchsia's linux and mac clang builder. Failed build can be seen at: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8830380874445931681/overview
>> Could you revert the change if the fix will take a while? Thanks.
>
> @ldionne @phosek I think the Fuchsia build failure is because they ingest the libcxx CMakeLists.txt directly, without going through the one in runtimes/. Should we reconsider setting `LLVM_THIRD_PARTY_DIR` in runtimes/CMakeLists.txt, and, instead, set it separately in libcxx and libc's CMakeLists?
>
> or, is the way Fuchsia is ingesting libcxx's CMakeLists incorrect?

That's not an issue with the Fuchsia build, it's an issue with the libFuzzer build which we include in our toolchain build.

libFuzzer on Linux and Fuchsia uses a private copy of libc++ and that build still build still goes through `libcxx/CMakeLists.txt`, see:

https://github.com/llvm/llvm-project/blob/01510ac08474a6c4beae033794b71b6b5ab1e89d/compiler-rt/lib/fuzzer/CMakeLists.txt#L160
https://github.com/llvm/llvm-project/blob/01510ac08474a6c4beae033794b71b6b5ab1e89d/compiler-rt/cmake/Modules/AddCompilerRT.cmake#L546
https://github.com/llvm/llvm-project/blob/01510ac08474a6c4beae033794b71b6b5ab1e89d/compiler-rt/cmake/Modules/CustomLibcxx/CMakeLists.txt

We need to change it to use `runtimes/CMakeLists.txt` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012