[libcxx-commits] [PATCH] D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party

[Mircea Trofin via Phabricator via libcxx-commits]

mtrofin added a comment.

In D112012#3136235 <https://reviews.llvm.org/D112012#3136235>, @haowei wrote:

> This change broke Fuchsia's linux and mac clang builder. Failed build can be seen at: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8830380874445931681/overview
> Could you revert the change if the fix will take a while? Thanks.

@ldionne @phosek I think the Fuchsia build failure is because they ingest the libcxx CMakeLists.txt directly, without going through the one in runtimes/. Should we reconsider setting `LLVM_THIRD_PARTY_DIR` in runtimes/CMakeLists.txt, and, instead, set it separately in libcxx and libc's CMakeLists?

or, is the way Fuchsia is ingesting libcxx's CMakeLists incorrect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012