[libcxx-commits] [PATCH] D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp:57
+    (void)std::for_each(first, last, [](void*){});
+#if TEST_STD_VER >= 17
+    (void)std::for_each_n(first, count, [](void*){});
----------------
Mordante wrote:
> Quuxplusone wrote:
> > Mordante wrote:
> > > Is there a reason to change from our usual pattern of `#if TEST_STD_VER > 14`?
> > > IIRC this question was raised in a review not that long ago, but I don't recall that we wanted to move to this style.
> > Well, this isn't a "change" for this particular piece of code; I did it with `>=` in D92776 for some reason.
> > I don't object to changing it from `>=` to `>` in this same PR, as long as we're confusing Phab anyway. :)
> There are still some `>=`'s left.
My intent is that the only `>=`s left are for `>= 11`, where that seems to be our style:
```
$ git grep -ho 'TEST_STD_VER >[=]* [0-9]*' ../libcxx/test/ | sort | uniq -c | sort -n
  15 TEST_STD_VER > 3
  20 TEST_STD_VER > 03
  37 TEST_STD_VER >= 17
  92 TEST_STD_VER >= 20
 110 TEST_STD_VER > 20
 181 TEST_STD_VER >= 14
 309 TEST_STD_VER > 11
 381 TEST_STD_VER > 14
 474 TEST_STD_VER > 17
1259 TEST_STD_VER >= 11
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113906/new/

https://reviews.llvm.org/D113906