[libcxx-commits] [PATCH] D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

One nit for me left.



================
Comment at: libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp:57
+    (void)std::for_each(first, last, [](void*){});
+#if TEST_STD_VER >= 17
+    (void)std::for_each_n(first, count, [](void*){});
----------------
Quuxplusone wrote:
> Mordante wrote:
> > Is there a reason to change from our usual pattern of `#if TEST_STD_VER > 14`?
> > IIRC this question was raised in a review not that long ago, but I don't recall that we wanted to move to this style.
> Well, this isn't a "change" for this particular piece of code; I did it with `>=` in D92776 for some reason.
> I don't object to changing it from `>=` to `>` in this same PR, as long as we're confusing Phab anyway. :)
There are still some `>=`'s left.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113906/new/

https://reviews.llvm.org/D113906