[libcxx-commits] [PATCH] D109433: [libcxx] [coroutine] Conform coroutine implementation

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 15 14:53:53 PST 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:134-137
+  __coroutine/coroutine_handle.h
+  __coroutine/noop_coroutine_handle.h
+  __coroutine/coroutine_traits.h
+  __coroutine/coroutine_trivial_awaitables.h
----------------
ldionne wrote:
> Please sort!
And before sorting, please rename `coroutine_trivial_awaitables` to just `trivial_awaitables` (and update the modulemap, and the header guard, and the generated tests). I just noticed this. :P


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109433/new/

https://reviews.llvm.org/D109433



More information about the libcxx-commits mailing list