[libcxx-commits] [PATCH] D109433: [libcxx] [coroutine] Conform coroutine implementation

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM with some suggestions. I am assuming that you copy-pasted the code and tests from `experimental/coroutine` and performed minor modifications as explained in the description.

Thanks!



================
Comment at: libcxx/include/CMakeLists.txt:134-137
+  __coroutine/coroutine_handle.h
+  __coroutine/noop_coroutine_handle.h
+  __coroutine/coroutine_traits.h
+  __coroutine/coroutine_trivial_awaitables.h
----------------
Please sort!


================
Comment at: libcxx/include/__coroutine/coroutine_handle.h:97
+// [coroutine.handle.compare]
+#if defined(_LIBCPP_HAS_NO_SPACESHIP_OPERATOR)
+
----------------
I *think* this block can be removed entirely, but let's not block this on D113938.


================
Comment at: libcxx/include/__coroutine/noop_coroutine_handle.h:23
+
+#if __has_builtin(__builtin_coro_noop)
+// [coroutine.noop]
----------------
Can we get rid of this (and similarly in the corresponding test file)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109433/new/

https://reviews.llvm.org/D109433