[libcxx-commits] [PATCH] D92397: [libc++] Always define a key function for std::bad_function_call in the dylib

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

In D92397#3132906 <https://reviews.llvm.org/D92397#3132906>, @ldionne wrote:

> This LGTM, but I don't understand why the ABI list doesn't contain `_ZNKSt9exception4whatEv` anymore. Let's try to figure that out before we land.
>
> This seemingly simple patch is full of surprises.

Hmm, I don't know how exactly the `generate-cxx-abilist` build works, but I presumed that it defines `_LIBCPP_BUILDING_LIBRARY` but doesn't define `GOOD_WHAT_MESSAGE`, which I think would lead to the output we're seeing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92397/new/

https://reviews.llvm.org/D92397