[libcxx-commits] [PATCH] D113027: [libcxx] Remove nonstandard _FilesystemClock::{to, from}_time_t

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D113027#3131369 <https://reviews.llvm.org/D113027#3131369>, @alexfh wrote:

> In D113027#3125511 <https://reviews.llvm.org/D113027#3125511>, @mstorsjo wrote:
>
>> https://reviews.llvm.org/D113430 landed now, which should have implemented the standard methods instead.
>
> There is code out there, which already relies on these non-standard functions and it's going to be broken by this change without a reasonable alternative (migrating the code to C++20 is not a real alternative).

Why is migrating to C++20 not a real alternative? Just curious.

I would suggest we do this:

1. Add the methods back unless `_LIBCPP_ENABLE_REMOVED_FILE_CLOCK_TIME_T_METHODS` is defined.
2. Update the release note to mention that folks can use that macro to re-enable the methods temporarily, but that the option will be removed in two releases so they should move to C++20.

Whoever is broken by this will see the breakage, then read the release notes, define `_LIBCPP_ENABLE_REMOVED_FILE_CLOCK_TIME_T_METHODS`, and make a note to move to C++20 before they are broken for good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113027/new/

https://reviews.llvm.org/D113027