[libcxx-commits] [PATCH] D113027: [libcxx] Remove nonstandard _FilesystemClock::{to, from}_time_t

[Reid Kleckner via Phabricator via libcxx-commits]

rnk added a comment.

In D113027#3131371 <https://reviews.llvm.org/D113027#3131371>, @mstorsjo wrote:

> How do you handle this with other C++ libraries, do they provide `to_sys`/`from_sys` even before C++20, or do they use some other nonstandard method, or were you only using this setup on libc++?

The code in question only uses libc++.

One thing that jumps out to me is that these methods were not uglified, not in the implementor's namespace, so users could reasonably consider them to be stable. To me, that seems like a good argument for reverting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113027/new/

https://reviews.llvm.org/D113027