[libcxx-commits] [PATCH] D109433: [libcxx] [coroutine] Conform coroutine implementation

Thu Nov 11 18:41:41 PST 2021

ChuanqiXu added a comment.

In D109433#3124512 <https://reviews.llvm.org/D109433#3124512>, @Quuxplusone wrote:

> In D109433#3123703 <https://reviews.llvm.org/D109433#3123703>, @ChuanqiXu wrote:
>
>> [`gdb_pretty_printer_test.sh.cpp` is failing]
>>
>> It looks like this is introduced in https://reviews.llvm.org/D113112. @ldionne hi, could you help to look into this? @Quuxplusone Now I think this test failure should be irrelevant with this diff and all other tests are passed. Do you think we should land this after the bug fixed or we could land this now?
>
>
>
> - I'm 100% sure that the GDB-pretty-printer test failure is not your fault.
> - I think @ldionne should look into it (in fact, my impression is that he already is). Maybe the solution will just be to UNSUPPORTED it temporarily, but let's actually get it green.
> - IMO this coroutines stuff is big and important enough that **you should wait** until that pretty-printer test has been fixed, and get a really 100% green CI run, before you land it. It's been a few months; waiting another few days won't hurt anything. And green CI runs for big features are nice to have. So I **don't** think you should land it until CI is green.

Got it. Thanks for the explanation!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109433/new/

https://reviews.llvm.org/D109433