[libcxx-commits] [PATCH] D109433: [libcxx] [coroutine] Conform coroutine implementation
Chuanqi Xu via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Nov 10 04:19:06 PST 2021
ChuanqiXu updated this revision to Diff 386120.
ChuanqiXu added a comment.
Fix the test failure for generic modules.
I finally found the reason why it would fail for generic modules. Since the tests didn't contain headers which is included in the `__coroutine/*` headers even if they are already included! It is surprising to people who didn't use clang module before. Then the only failure is for libcxx/gdb/gdb_pretty_printer_test.sh.cpp. It looks not relevant with coroutines. But I would try to look into it in case it would fail still.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109433/new/
https://reviews.llvm.org/D109433
Files:
libcxx/docs/FeatureTestMacroTable.rst
libcxx/docs/Status/Cxx20Issues.csv
libcxx/docs/Status/SpaceshipProjects.csv
libcxx/include/CMakeLists.txt
libcxx/include/__config
libcxx/include/__coroutine/coroutine_handle.h
libcxx/include/__coroutine/coroutine_traits.h
libcxx/include/__coroutine/coroutine_trivial_awaitables.h
libcxx/include/__coroutine/noop_coroutine_handle.h
libcxx/include/coroutine
libcxx/include/experimental/__config
libcxx/include/experimental/coroutine
libcxx/include/module.modulemap
libcxx/include/version
libcxx/test/libcxx/diagnostics/detail.headers/coroutine/coroutine_handle.module.verify.cpp
libcxx/test/libcxx/diagnostics/detail.headers/coroutine/coroutine_traits.module.verify.cpp
libcxx/test/libcxx/diagnostics/detail.headers/coroutine/coroutine_trivial_awaitables.module.verify.cpp
libcxx/test/libcxx/diagnostics/detail.headers/coroutine/noop_coroutine_handle.module.verify.cpp
libcxx/test/libcxx/double_include.sh.cpp
libcxx/test/libcxx/inclusions/coroutine.inclusions.compile.pass.cpp
libcxx/test/libcxx/min_max_macros.compile.pass.cpp
libcxx/test/libcxx/no_assert_include.compile.pass.cpp
libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.capacity/operator_bool.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.compare/equal_comp.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.compare/less_comp.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.completion/done.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.con/assign.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.con/construct.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.export/address.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.export/from_address.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.hash/hash.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.noop/noop_coroutine.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/promise.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.resumption/destroy.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.resumption/resume.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.handle/void_handle.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.traits/promise_type.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.trivial.awaitables/suspend_always.pass.cpp
libcxx/test/std/language.support/support.coroutines/coroutine.trivial.awaitables/suspend_never.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/await_result.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/expected.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/generator.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/go.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp
libcxx/test/std/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp
libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.pass.cpp
libcxx/test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp
libcxx/test/support/coroutine_types.h
libcxx/utils/generate_feature_test_macro_components.py
libcxx/utils/generate_header_inclusion_tests.py
libcxx/utils/generate_header_tests.py
libcxx/utils/libcxx/test/features.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109433.386120.patch
Type: text/x-patch
Size: 100823 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211110/7584fff6/attachment-0001.bin>
More information about the libcxx-commits
mailing list