[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

Tue Nov 9 02:11:54 PST 2021

phosek added a comment.

In D88458#3117828 <https://reviews.llvm.org/D88458#3117828>, @Abpostelnicu wrote:

> In D88458#3117814 <https://reviews.llvm.org/D88458#3117814>, @phosek wrote:
>
>> It looks to me like you're using the pre-monorepo layout where you move `compiler-rt` to `llvm/projects`, is that correct?
>
> Yes, you are correct.

Is there any particular reason for doing this rather than simply using the monorepo layout?

>> We could make it work, but I'm not sure if we should. The monorepo layout is the only supported one and we've already discussed the plans to remove the non-monorepo layout support to simplify our build.
>
> It would be better to make it work, removing support for the old build system will break many toolchains.

So far you're the only one who reached affected by this change which to me suggests that there may not be many projects using the old layout.

When LLVM adopted the monorepo we made no guarantees that we would keep the old layout working.

We're also planning larger build changes after LLVM 14 which will likely disrupt you, see https://lists.llvm.org/pipermail/llvm-dev/2021-October/153238.html.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458