[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

[Andi via Phabricator via libcxx-commits]

Abpostelnicu added a comment.

In D88458#3117814 <https://reviews.llvm.org/D88458#3117814>, @phosek wrote:

> In D88458#3117759 <https://reviews.llvm.org/D88458#3117759>, @Abpostelnicu wrote:
>
>> Sure, is this something that helps https://paste.mozilla.org/yxUYUBk3 ?
>
> Yes, thank you. The issue is this:
>
>   CMake Error at projects/compiler-rt/cmake/Modules/AddCompilerRT.cmake:3 (include):
>   include could not find load file:
>   
>   /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/../cmake/Modules/HandleCompilerRT.cmake
>   Call Stack (most recent call first):
>   projects/compiler-rt/lib/CMakeLists.txt:4 (include)
>
> It looks to me like you're using the pre-monorepo layout where you move `compiler-rt` to `llvm/projects`, is that correct?

Yes, you are correct.

> We could make it work, but I'm not sure if we should. The monorepo layout is the only supported one and we've already discussed the plans to remove the non-monorepo layout support to simplify our build.

It would be better to make it work, removing support for the old build system will break many toolchains.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458