[libcxx-commits] [PATCH] D112215: [libcxx] [ci] Add CI configurations for MinGW

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 8 14:46:03 PST 2021


mstorsjo added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:509
   # Tests on non-Unix platforms
-  - label: "Windows (DLL)"
-    command: "bash libcxx/utils/ci/run-buildbot windows-dll"
+  - label: "MSVC (DLL)"
+    command: "bash libcxx/utils/ci/run-buildbot msvc-dll"
----------------
mstorsjo wrote:
> ldionne wrote:
> > I would prefer `Clang-cl` or something like that. For me, MSVC refers to the real MSVC compiler, not the Clang emulation.
> Ok, fair enough.
Btw, one reason why I first chose to avoid naming it clang-cl, is that when running tests, we actually don’t run the `clang-cl` compiler fronted, but call the gcc style driver with `-target *-windows-msvc`. But I guess clang-cl still is close enough, and more concise than “clang in msvc mode”.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112215/new/

https://reviews.llvm.org/D112215



More information about the libcxx-commits mailing list