[libcxx-commits] [PATCH] D112215: [libcxx] [ci] Add CI configurations for MinGW

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:509
   # Tests on non-Unix platforms
-  - label: "Windows (DLL)"
-    command: "bash libcxx/utils/ci/run-buildbot windows-dll"
+  - label: "MSVC (DLL)"
+    command: "bash libcxx/utils/ci/run-buildbot msvc-dll"
----------------
ldionne wrote:
> I would prefer `Clang-cl` or something like that. For me, MSVC refers to the real MSVC compiler, not the Clang emulation.
Ok, fair enough.


================
Comment at: libcxx/utils/ci/run-buildbot:634
+    echo "+++ Running the libc++ tests"
+    ${NINJA} -vC "${BUILD_DIR}" check-cxx
+;;
----------------
ldionne wrote:
> We don't run the libc++abi tests?
No, those don't work on Windows/MinGW yet, afaik.


================
Comment at: libcxx/utils/ci/run-buildbot:651
+    echo "+++ Running the libc++ tests"
+    ${NINJA} -vC "${BUILD_DIR}" check-cxx
+;;
----------------
ldionne wrote:
> It seems to me that the tests should have a dependency on libunwind if we are linking them against the just-built libunwind, no? Ideally we'd fix that in a separate patch before landing this.
I guess that could be handled with a cmake rule like this:
```
if (LIBCXXABI_USE_LLVM_UNWINDER)
  list(APPEND LIBCXX_TEST_DEPS unwind)
endif()
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112215/new/

https://reviews.llvm.org/D112215