[libcxx-commits] [PATCH] D113348: [libc++] [test] Eliminate the libcpp-no-if-constexpr feature flag.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

There's also an instance of `__cpp_if_constexpr` in `libcxx/test/support/container_debug_tests.h` you can remove.



================
Comment at: libcxx/utils/libcxx/test/features.py:39
   Feature(name='fdelayed-template-parsing',     when=lambda cfg: hasCompileFlag(cfg, '-fdelayed-template-parsing')),
-  Feature(name='libcpp-no-if-constexpr',        when=lambda cfg: '__cpp_if_constexpr' not in featureTestMacros(cfg)),
   Feature(name='libcpp-no-structured-bindings', when=lambda cfg: '__cpp_structured_bindings' not in featureTestMacros(cfg)),
   Feature(name='libcpp-no-concepts',            when=lambda cfg: featureTestMacros(cfg).get('__cpp_concepts', 0) < 201907),
----------------
Mordante wrote:
> Incidentally I've been looking at this recently and I think `libcpp-no-structured-bindings` and `no-noexcept-function-type` can also be removed. Obviously not intended for this patch.
Yup, there's some more cleanup we can do!!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113348/new/

https://reviews.llvm.org/D113348