[libcxx-commits] [PATCH] D113348: [libc++] [test] Eliminate the libcpp-no-if-constexpr feature flag.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Nov 6 12:23:35 PDT 2021


Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks for looking at this! If the CI's happy, I'm happy.



================
Comment at: libcxx/utils/libcxx/test/features.py:39
   Feature(name='fdelayed-template-parsing',     when=lambda cfg: hasCompileFlag(cfg, '-fdelayed-template-parsing')),
-  Feature(name='libcpp-no-if-constexpr',        when=lambda cfg: '__cpp_if_constexpr' not in featureTestMacros(cfg)),
   Feature(name='libcpp-no-structured-bindings', when=lambda cfg: '__cpp_structured_bindings' not in featureTestMacros(cfg)),
   Feature(name='libcpp-no-concepts',            when=lambda cfg: featureTestMacros(cfg).get('__cpp_concepts', 0) < 201907),
----------------
Incidentally I've been looking at this recently and I think `libcpp-no-structured-bindings` and `no-noexcept-function-type` can also be removed. Obviously not intended for this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113348/new/

https://reviews.llvm.org/D113348



More information about the libcxx-commits mailing list