[libcxx-commits] [PATCH] D102359: [libc++] [test] Fix a few tests for 32-bit x86

Mon May 31 09:34:24 PDT 2021

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.

================
Comment at: libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp:18

 // XFAIL: LIBCXX-WINDOWS-FIXME

----------------
hvdijk wrote:
> ldionne wrote:
> > Can we instead use `// XFAIL: target-x86`?
> Marking this as XFAIL would suggest to me that there is a bug that we're ignoring for now. I don't think there is: _LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI is behaving exactly as intended, unique_ptr is passed exactly as a trivial type.
`XFAIL` is also used when the test is expected to fail because the tested behavior doesn't apply to the given configuration - or at least we've been using it for that. But I can see your point, and I'm fine with the current approach.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102359/new/

https://reviews.llvm.org/D102359