[libcxx-commits] [PATCH] D102359: [libc++] [test] Fix a few tests for 32-bit x86

[Harald van Dijk via Phabricator via libcxx-commits]

hvdijk added inline comments.


================
Comment at: libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp:18
 
 // XFAIL: LIBCXX-WINDOWS-FIXME
 
----------------
ldionne wrote:
> Can we instead use `// XFAIL: target-x86`?
Marking this as XFAIL would suggest to me that there is a bug that we're ignoring for now. I don't think there is: _LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI is behaving exactly as intended, unique_ptr is passed exactly as a trivial type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102359/new/

https://reviews.llvm.org/D102359