[libcxx-commits] [PATCH] D103330: [libcxx][nfc] splices non-modifying algorithms into their own headers

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 31 08:20:21 PDT 2021


Quuxplusone added a comment.

As usual, I'll leave my for-the-record comment that I //really// don't like this direction. It makes tons of little headers for no benefit... and I smell the upcoming PR where you add a bunch of C++20 Ranges dependencies into all of these little headers, making compilation slower for C++17 programs and complexifying the dependency graph.

Notice the failing Modules test; that's being discussed in the comments on D102781 <https://reviews.llvm.org/D102781>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103330/new/

https://reviews.llvm.org/D103330



More information about the libcxx-commits mailing list