[libcxx-commits] [PATCH] D103330: [libcxx][nfc] splices non-modifying algorithms into their own headers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 31 08:09:18 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but can you please keep including `<functional>` in `<algorithm>` for now? Add a comment saying `// TODO: Remove this include when we're sure it won't break people`.

You can then perform the removal immediately after, but in a separate commit. The reason is that I suspect it's going to break a lot of code (which does not include-what-they-use), and so having a separate commit just to toggle that include is going to be helpful for vendors. For example, I might have to temporarily revert that commit for shipping it on Apple platforms until some internal stuff has been fixed - I suspect other vendors will be in the same boat.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list