[libcxx-commits] [PATCH] D103398: [libcxx] Define LIBCPP_HAS_TIMESPEC_GET for MSVC configurations

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

This define was out of sync with the corresponding define in tests, it
was added inconsistently in 171c77b7dad4a050aca23ff7ca1b75f87560fefb.

Modern MSVC environments do have these typedefs and functions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103398

Files:
  libcxx/include/__config
  libcxx/test/libcxx/language.support/has_timespec_get.compile.pass.cpp
  libcxx/test/std/language.support/support.runtime/ctime.pass.cpp
  libcxx/test/std/utilities/time/date.time/ctime.pass.cpp


Index: libcxx/test/std/utilities/time/date.time/ctime.pass.cpp
===================================================================
--- libcxx/test/std/utilities/time/date.time/ctime.pass.cpp
+++ libcxx/test/std/utilities/time/date.time/ctime.pass.cpp
@@ -6,8 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <ctime>
 #include <type_traits>
 
Index: libcxx/test/std/language.support/support.runtime/ctime.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.runtime/ctime.pass.cpp
+++ libcxx/test/std/language.support/support.runtime/ctime.pass.cpp
@@ -8,8 +8,6 @@
 
 // test <ctime>
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <ctime>
 #include <type_traits>
 #include "test_macros.h"
Index: libcxx/test/libcxx/language.support/has_timespec_get.compile.pass.cpp
===================================================================
--- libcxx/test/libcxx/language.support/has_timespec_get.compile.pass.cpp
+++ libcxx/test/libcxx/language.support/has_timespec_get.compile.pass.cpp
@@ -8,8 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // Make sure TEST_HAS_TIMESPEC_GET (defined by the test suite) and
 // _LIBCPP_HAS_TIMESPEC_GET (defined by libc++) stay in sync.
 
Index: libcxx/include/__config
===================================================================
--- libcxx/include/__config
+++ libcxx/include/__config
@@ -390,6 +390,9 @@
 #      define _LIBCPP_HAS_QUICK_EXIT
 #      define _LIBCPP_HAS_TIMESPEC_GET
 #    endif
+#  elif defined(_LIBCPP_MSVCRT)
+     // Using Microsoft's C Runtime library, not MinGW
+#    define _LIBCPP_HAS_TIMESPEC_GET
 #  elif defined(__APPLE__)
      // timespec_get and aligned_alloc were introduced in macOS 10.15 and
      // aligned releases


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103398.348768.patch
Type: text/x-patch
Size: 1885 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210531/e0f80670/attachment.bin>