[libcxx-commits] [libcxx] 7d7b72b - [libcxx] [test] Add UNSUPPORTED: msvc in a couple verify.cpp tests

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 31 00:58:53 PDT 2021


Author: Martin Storsjö
Date: 2021-05-31T10:58:32+03:00
New Revision: 7d7b72bad7ff1fc22c79d535826de43452f3379d

URL: https://github.com/llvm/llvm-project/commit/7d7b72bad7ff1fc22c79d535826de43452f3379d
DIFF: https://github.com/llvm/llvm-project/commit/7d7b72bad7ff1fc22c79d535826de43452f3379d.diff

LOG: [libcxx] [test] Add UNSUPPORTED: msvc in a couple verify.cpp tests

Due to issues with the detection of the clang-verify feature, these
tests have been skipped in the Windows CI configuration so far.

Differential Revision: https://reviews.llvm.org/D103308

Added: 
    

Modified: 
    libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
    libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp b/libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
index 7fd6749aefd16..55353f5007d67 100644
--- a/libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
+++ b/libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
@@ -10,6 +10,10 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // UNSUPPORTED: apple-clang-9, apple-clang-10, apple-clang-11, apple-clang-12.0.0
 
+// In MSVC mode, there's a slightly 
diff erent number of errors printed for
+// each of these, so it doesn't add up to the exact expected count of 18.
+// UNSUPPORTED: msvc
+
 // <compare>
 
 // Ensure we reject all cases where an argument other than a literal 0 is used

diff  --git a/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp b/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp
index 928f734a05dd0..86954017c0839 100644
--- a/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp
+++ b/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp
@@ -8,6 +8,10 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // type_traits
 
+// MSVC mode seems to use 
diff erent rules regarding enum sizes, so E1
+// doesn't cause an error.
+// UNSUPPORTED: msvc
+
 // underlying_type
 // Mandates: enum must not be an incomplete enumeration type.
 


        


More information about the libcxx-commits mailing list