[libcxx-commits] [PATCH] D103295: [libcxx][docs] updates the ranges status paper

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 28 11:11:50 PDT 2021


cjdb added a comment.

In D103295#2787355 <https://reviews.llvm.org/D103295#2787355>, @zoecarver wrote:

> 2. Where are the other algorithms? Is that a different paper?

They're (mostly) in P0896. I don't think we got around to adding these because there's >100 of them. Now that we're starting to fix our eye on algorithms, we should probably start thinking about adding them (but not in this patch).

> 1. Seems we're missing drop_view (and always have been).

This doc currently cares only about P0896 <http://wg21.link/P0896> ± some small edits that I made to make the doc more readable. `drop_view` was added in P1035 <http://wg21.link/P1035>, which is why it's not (yet) present.
I think there should be a few follow-up patches: one for adding algos, and possibly one for each of the other ranges papers and issues (just one commit for all the issues).

> 4. This is me being pedantic: for some reason some of these are left-justified and others aren't (maybe >1 item is centered). Is there some way to fix this (so they're all left-justified)?

They all look left-justified to me. Which ones look centred to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103295/new/

https://reviews.llvm.org/D103295



More information about the libcxx-commits mailing list