[libcxx-commits] [PATCH] D103308: [libcxx] [test] Add UNSUPPORTED: msvc in a couple verify.cpp tests

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 28 04:19:20 PDT 2021

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Due to issues with the detection of the clang-verify feature, these
tests have been skipped in the Windows CI configuration so far.

  rG LLVM Github Monorepo



Index: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp
--- libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp
+++ libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp
@@ -8,6 +8,10 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // type_traits
+// MSVC mode seems to use different rules regarding enum sizes, so E1
+// doesn't cause an error.
 // underlying_type
 // Mandates: enum must not be an incomplete enumeration type.
Index: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
--- libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
+++ libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
@@ -10,6 +10,10 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // UNSUPPORTED: apple-clang-9, apple-clang-10, apple-clang-11, apple-clang-12.0.0
+// In MSVC mode, there's a slightly different number of errors printed for
+// each of these, so it doesn't add up to the exact expected count of 18.
 // <compare>
 // Ensure we reject all cases where an argument other than a literal 0 is used

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103308.348488.patch
Type: text/x-patch
Size: 1355 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210528/13142f9d/attachment.bin>

More information about the libcxx-commits mailing list