[libcxx-commits] [PATCH] D102194: [libcxx][test] Split more debug mode tests

[Kristina Bessonova via Phabricator via libcxx-commits]

krisb added a comment.

@Quuxplusone, thank you for reviewing this!



================
Comment at: libcxx/test/libcxx/containers/sequences/vector/db_cindex.pass.cpp:31-33
     assert(c[0] == 0);
     assert(c[1] == 0);
     assert(false);
----------------
Quuxplusone wrote:
> I'm confused by this sequence of asserts. :)
> Is the intent that D102194 is just a minimal diff to split up these tests (even though the split-up tests remain nonsensical), and then you'll make them less nonsensical via D100595? If so, then OK.
Yes, the intent of this patch is to make some preparations for D100595 so it can be a little bit smaller. All other changes (like removing redundant includes, fixing asserts, and so on) I'm going to address in D100595 for all the debug mode tests at once. I'll update D100595 when all the dependencies get landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102194/new/

https://reviews.llvm.org/D102194