[libcxx-commits] [PATCH] D102194: [libcxx][test] Split more debug mode tests

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/libcxx/containers/sequences/vector/db_cindex.pass.cpp:31-33
     assert(c[0] == 0);
     assert(c[1] == 0);
     assert(false);
----------------
I'm confused by this sequence of asserts. :)
Is the intent that D102194 is just a minimal diff to split up these tests (even though the split-up tests remain nonsensical), and then you'll make them less nonsensical via D100595? If so, then OK.


================
Comment at: libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_db2.pass.cpp:20-21
 #include <cassert>
 #include <cstdlib>
 #include <exception>
 
----------------
FWIW, `cstdlib` and `exception` are unused here, and there's probably a lot more of this kind of thing throughout the debug tests. Maybe you want to address it in D100595.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102194/new/

https://reviews.llvm.org/D102194