[libcxx-commits] [PATCH] D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 11 12:11:14 PDT 2021

Mordante requested changes to this revision.
Mordante added inline comments.
This revision now requires changes to proceed.

Comment at: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp:22
   void(v op 0L);                                                               \
   void(0L op v);                                                               \
   void(v op nullptr);                                                          \
I think I wasn't clear what I meant for the `TEST_PASS`. After your change the `0L` is valid. This is the reason the number of errors reduced from 18 to 12. So after removing the two lines above the test still passes. This was the part I wanted to have in `TEST_PASS`.

Is allowing `0L` really intended? Looking at D85051 it seems @rsmith's intention to prohibit `0L`.

If it's intended please adjust the unit test, the patch description, and the unit tests to split the `TEST_FAIL` unit test in a fail and pass part..

Comment at: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp:42
+  TEST_PASS(v, ==);
+  TEST_PASS(v, !=);
Even if I didn't ask for this macro, I still like it better than the previous code :-)

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list