[libcxx-commits] [PATCH] D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp:25
   void(nullptr op v);                                                          \
   void(v op(1 - 1));                                                           \
+  void((1 - 1) op v)
----------------
Minor clang-format-induced misformatting here.


================
Comment at: libcxx/test/std/language.support/cmp/cmp.strongord/strongord.pass.cpp:57-58
+#ifndef TEST_HAS_NO_SPACESHIP_OPERATOR
+  auto& StrongEq = std::strong_ordering::equal;
+  auto& PartialEq = std::partial_ordering::equivalent;
+  assert(StrongEq == PartialEq);
----------------
Btw, it is bizarre to me that (throughout the existing code) we take `auto&` of all these values, instead of making copies with `auto`. Is there a subtle reason for the `&` to be here (throughout)? My only wild guess is that it's something broken about constexpr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101708/new/

https://reviews.llvm.org/D101708