[libcxx-commits] [PATCH] D101731: [libcxx] [test] Fix fs.op.last_write_time for Windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 10 09:28:52 PDT 2021

mstorsjo added a comment.

In D101731#2748135 <https://reviews.llvm.org/D101731#2748135>, @Mordante wrote:

> It seems the build failed since the patch couldn't be applied. Does this patch depend on other patches?

No, but there's other lines changed closeby by another recently applied patch, regarding the XFAIL lines - rebasing past that and reposting for CI.

Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:92
+} // namespace compat
Mordante wrote:
> mstorsjo wrote:
> > Mordante wrote:
> > > Please move this line outside the `#if` section
> > If we'd keep the namespace, I wouldn't want to move the ending brace of the namespace outside of the ifdef as long as the starting brace is within the ifdef, that'd be awfully imbalanced. But we can get rid of it altogether.
> I thought the namespace started before the initial `#if`. Maybe I misread. But with this version of the patch the comment no longer applies.
No, it started within the `#if`. But the question is moot in this revision anyway.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list