[libcxx-commits] [PATCH] D101731: [libcxx] [test] Fix fs.op.last_write_time for Windows

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 10 09:22:27 PDT 2021

Mordante accepted this revision as: Mordante.
Mordante added a comment.

It seems the build failed since the patch couldn't be applied. Does this patch depend on other patches?
LGTM, but please make sure it passes CI before committing.

Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:92
+} // namespace compat
mstorsjo wrote:
> Mordante wrote:
> > Please move this line outside the `#if` section
> If we'd keep the namespace, I wouldn't want to move the ending brace of the namespace outside of the ifdef as long as the starting brace is within the ifdef, that'd be awfully imbalanced. But we can get rid of it altogether.
I thought the namespace started before the initial `#if`. Maybe I misread. But with this version of the patch the comment no longer applies.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list