[libcxx-commits] [PATCH] D102121: [libcxx][ranges] adds _`non-propagating-cache`_

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb updated this revision to Diff 343935.
cjdb added a comment.

removes `__emplace_deref`

> Can you update the status papers documentation and add a warning based on which version of the paper this feature has been implemented? If the wording changes before the paper is accepted we need to update our implementation     to match the final wording.

Done for D102119 <https://reviews.llvm.org/D102119>. I'm not sure if it's necessary to do it for this patch since the cache is an implementation detail and has always been necessary for C++20 ranges. Tying it to P2328 <https://reviews.llvm.org/P2328> implies that it's a C++23 addition, which isn't the case here. Regardless of what the committee decides to do with P2328 <https://reviews.llvm.org/P2328>, we //need// to keep this type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102121/new/

https://reviews.llvm.org/D102121

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__ranges/non_propagating_cache.h
  libcxx/test/libcxx/ranges/range.nonprop.cache/cache_disabled.compile.pass.cpp
  libcxx/test/libcxx/ranges/range.nonprop.cache/copy_assign.pass.cpp
  libcxx/test/libcxx/ranges/range.nonprop.cache/copy_ctor.pass.cpp
  libcxx/test/libcxx/ranges/range.nonprop.cache/move_assign.pass.cpp
  libcxx/test/libcxx/ranges/range.nonprop.cache/move_ctor.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102121.343935.patch
Type: text/x-patch
Size: 9607 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210509/f2ad1374/attachment.bin>