[libcxx-commits] [PATCH] D102121: [libcxx][ranges] adds _`non-propagating-cache`_

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Our normal policy is not to implement papers before they are accepted. I can understand why you want make an exception in this case. Can you update the status papers documentation and add a warning based on which version of the paper this feature has been implemented? If the wording changes before the paper is accepted we need to update our implementation to match the final wording.

This remark also applies to  D102119 <https://reviews.llvm.org/D102119>



================
Comment at: libcxx/include/__ranges/non_propagating_cache.h:2
+// -*- C++ -*-
+//===--------------------- __ranges/concepts.h ----------------------------===//
+//
----------------
Please update or remove the filename.


================
Comment at: libcxx/include/__ranges/non_propagating_cache.h:61
+    template<indirectly_readable _Ip>
+    requires std::constructible_from<_Tp, iter_reference_t<_Ip> >
+    constexpr _Tp& __emplace_deref(const _Ip& __i) {
----------------
Remove the `std::`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102121/new/

https://reviews.llvm.org/D102121