[libcxx-commits] [PATCH] D101737: [libcxx] Implement view.interface.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/include/__ranges/view_interface.h:117
+  template<class _D2 = _Derived>
+  [[nodiscard]] constexpr auto size() const
+    noexcept(noexcept(ranges::end(__derived()) - ranges::begin(__derived())))
----------------
Quuxplusone wrote:
> zoecarver wrote:
> > Remove all the nodiscards except for empty. 
> It would be appropriate to mark them `_LIBCPP_NODISCARD_EXT` (with tests).
> Remove all the nodiscards except for empty.

Please elaborate.

> It would be appropriate to mark them `_LIBCPP_NODISCARD_EXT` (with tests).

Why is this different to `[[nodiscard]]` + disabling the warning?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101737/new/

https://reviews.llvm.org/D101737