[libcxx-commits] [PATCH] D101737: [libcxx] Implement view.interface.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__ranges/view_interface.h:117
+  template<class _D2 = _Derived>
+  [[nodiscard]] constexpr auto size() const
+    noexcept(noexcept(ranges::end(__derived()) - ranges::begin(__derived())))
----------------
zoecarver wrote:
> Remove all the nodiscards except for empty. 
It would be appropriate to mark them `_LIBCPP_NODISCARD_EXT` (with tests).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101737/new/

https://reviews.llvm.org/D101737