[libcxx-commits] [PATCH] D101730: [libcxx] deprecates/removes `std::raw_storage_iterator`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

We should also amend the `<memory>` synopsis with `// deprecated in C++17, removed in C++20`.

LGTM with my and Arthur's suggestions.

Note that if that were a more widely used type, I'd request that we add an escape hatch for users to get the type back in C++20. I hate those, but sometimes they are a necessity if we want to be able to ship the library to users. In this case I think it won't be necessary.



================
Comment at: libcxx/test/std/utilities/memory/storage.iterator/deprecated.verify.cpp:15
+
+#include "test_macros.h"
+
----------------
This include is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101730/new/

https://reviews.llvm.org/D101730