[libcxx-commits] [PATCH] D101730: [libcxx] deprecates/removes `std::raw_storage_iterator`

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun May 2 19:10:19 PDT 2021


Quuxplusone added a comment.

Looks like you need to `git grep -i p0619 libcxx/` and update at least one of those comments.
Also `git grep -i p0174`, although maybe nothing needs changing there? I'm assuming this doesn't //finish// p0174. (But you should check and see.)



================
Comment at: libcxx/test/std/utilities/memory/storage.iterator/deprecated.verify.cpp:9
+
+// UNSUPPORTED: c++03, c++11, c++14, c++20, c++2b
+
----------------
cjdb wrote:
> Quuxplusone wrote:
> > `REQUIRES: c++17`
> Thanks. Is there a way to say `REQUIRES: <less-than-std>`? It'd be sucky if we needed to add `c++2c, c++2d, ...`.
IIUC, you're asking about this syntax, which is indeed supported.
```
// REQUIRES: c++03 || c++11 || c++14
```
Look at the `auto_ptr` tests for some examples of that.


================
Comment at: libcxx/test/std/utilities/memory/storage.iterator/raw_storage_iterator.base.pass.cpp:9
 
+// UNSUPPORTED: c++20, c++2b
+
----------------
`// REQUIRES: c++03 || c++11 || c++14 || c++17`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101730/new/

https://reviews.llvm.org/D101730



More information about the libcxx-commits mailing list