[libcxx-commits] [PATCH] D101723: [libc++][NFC] Move format_error to its own header.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the review!

In D101723#2732299 <https://reviews.llvm.org/D101723#2732299>, @Quuxplusone wrote:

> I don't see anything stylistically wrong with this, but I'd like to see a rationale for why it's a good idea. What does having-this-in-a-separate-header buy us, physically?

I personally like small headers/files. I find them easier to navigate than large files. Since it seems libc++ is moving in that direction I'm happy to oblige. In this case there's another reason. Locally I've more `std::format` patches. Managing patch series where parts are stored in separate files makes it easier when rebasing the series. (These patches will be up for review in a later stage, for new I'm still improving them.)



================
Comment at: libcxx/include/__format/format_error.h:10-11
+
+#ifndef _LIBCPP___FORMAT_ERROR_H
+#define _LIBCPP___FORMAT_ERROR_H
+
----------------
Quuxplusone wrote:
> `_LIBCPP___FORMAT_FORMAT_ERROR_H`
Will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101723/new/

https://reviews.llvm.org/D101723