[libcxx-commits] [PATCH] D101723: [libc++][NFC] Move format_error to its own header.
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun May 2 13:08:19 PDT 2021
Quuxplusone added a comment.
I don't see anything stylistically wrong with this, but I'd like to see a rationale for why it's a good idea. What does having-this-in-a-separate-header buy us, physically?
================
Comment at: libcxx/include/__format/format_error.h:10-11
+
+#ifndef _LIBCPP___FORMAT_ERROR_H
+#define _LIBCPP___FORMAT_ERROR_H
+
----------------
`_LIBCPP___FORMAT_FORMAT_ERROR_H`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101723/new/
https://reviews.llvm.org/D101723
More information about the libcxx-commits
mailing list