[libcxx-commits] [PATCH] D99516: [libc++] Avoid <climits> dependency in <thread>

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Well, seems reasonable to me, even if I personally would use `double` instead of `long double`.

If my math is right: If the caller passes in "2^53 + 1 nanoseconds" as a `long long` and we lose precision by casting it to a `double` with 53 mantissa bits, we end up waiting for only 2^53 nanoseconds (i.e. the precision loss is on the order of one nanosecond every 104 days).

But anyway this seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99516/new/

https://reviews.llvm.org/D99516