[libcxx-commits] [PATCH] D99516: [libc++] Avoid <climits> dependency in <thread>
Joerg Sonnenberger via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 29 11:10:08 PDT 2021
joerg added inline comments.
Comment at: libcxx/include/thread:381
> Seems reasonable to me, but I do wonder:
> (1) Why does the old code even need to drag in `long double`? What's wrong with regular `double`? (This is in generic code where 99% of the time `__d` will just be plain old `std::chrono::seconds` or `std::chrono::milliseconds`, which are denominated in `long long`.)
> (2) What do the relevant unit tests look like?
I think the idea was to avoid loss of precision or the like if possible. I don't think there is a reasonable way to unit test this?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits