[libcxx-commits] [PATCH] D99359: [libc++] Re-enable macOS back-deployment testing
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 26 06:41:52 PDT 2021
ldionne added inline comments.
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/last_write_time.pass.cpp:13
+// The string reported on errors changed, which makes those tests fail when run
+// against already-released libc++'s.
> ldionne wrote:
> > @Quuxplusone In case you have a better idea.
> I guess it'd be nice to make the checks for error strings a bit more lenient, to match both older and newer versions of the lib.
It'd be nice to match old and new versions, but not weaken the tests too much nor add too much complexity. I looked into fixing this in `check_libcxx_string()`, but it's not clear to me it's worth the complexity.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits