[libcxx-commits] [PATCH] D99359: [libc++] Re-enable macOS back-deployment testing

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/last_write_time.pass.cpp:13
 
+// The string reported on errors changed, which makes those tests fail when run
+// against already-released libc++'s.
----------------
mstorsjo wrote:
> ldionne wrote:
> > @Quuxplusone In case you have a better idea.
> I guess it'd be nice to make the checks for error strings a bit more lenient, to match both older and newer versions of the lib.
It'd be nice to match old and new versions, but not weaken the tests too much nor add too much complexity. I looked into fixing this in `check_libcxx_string()`, but it's not clear to me it's worth the complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99359/new/

https://reviews.llvm.org/D99359