[libcxx-commits] [PATCH] D99359: [libc++] Re-enable macOS back-deployment testing

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 26 05:34:15 PDT 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/last_write_time.pass.cpp:13
 
+// The string reported on errors changed, which makes those tests fail when run
+// against already-released libc++'s.
----------------
ldionne wrote:
> @Quuxplusone In case you have a better idea.
I guess it'd be nice to make the checks for error strings a bit more lenient, to match both older and newer versions of the lib.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99359/new/

https://reviews.llvm.org/D99359



More information about the libcxx-commits mailing list