[libcxx-commits] [PATCH] D99095: [libcxx] [test] Add XFAIL LIBCXX-WINDOWS-FIXME in 124 tests that fail in the CI configuration
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 25 10:49:29 PDT 2021
mstorsjo added inline comments.
Comment at: libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.pass.cpp:16
+// XFAIL: LIBCXX-WINDOWS-FIXME
> mstorsjo wrote:
> > Mordante wrote:
> > > This file and the other `*.version.pass.cpp` are automatically generated by `utils/generate_feature_test_macro_components.py`. If a developer runs this script these changes will accidentally be reverted. I'm not sure what would be the best fix for now.
> > Those particular xfails can be removed with D99213
> Since D99213 has landed, could you commit a fix for them?
Didn't D99213 already remove them as part of that commit? At least the xfail in std/language.support/support.limits/support.limits.general/complex.version.pass.cpp should have been removed now. Or did I leave stray whitespace changes behind compared with how they're autogenerated?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits